Merged
Conversation
* feat: support transient storage opcodes (EIP-1153) * feat: support memory copying instruction (EIP-5656) * feat: Support cancun selfdestruct changes (EIP-6780) --------- Co-authored-by: Agusrodri <agusrodriguez2456@gmail.com> Co-authored-by: Ahmad Kaouk <ahmadkaouk.93@gmail.com>
RomarQ
approved these changes
Dec 20, 2024
RomarQ
approved these changes
Dec 20, 2024
Contributor
RomarQ
left a comment
RomarQ
left a comment
There was a problem hiding this comment.
We have been using these changes in moonbeam for a few months already.
Contributor
|
Most of these changes have been merged to master, the only missing one is #281 (EIP-6780: SELFDESTRUCT only in same transaction) |
sorpaas
reviewed
Jan 7, 2025
Member
sorpaas
left a comment
sorpaas
left a comment
There was a problem hiding this comment.
Some small grumbles, but otherwise LGTM.
| self.state.set_deleted(address); | ||
| if self.config.has_eip_6780 && !self.state.created(address) { | ||
| if address != target { | ||
| self.state.transfer(Transfer { |
Member
There was a problem hiding this comment.
You can move this statement out of if as it appears on both sides.
Author
There was a problem hiding this comment.
We have an inner if statment (if address != target {) in one of the sides. I don't think we can move it out without making it complicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 2 new opcodes (
TLOADandTSTORE) for manipulating state that behaves almost identically to storage but is discarded after every transaction.Adds a new opcode (
MCOPY) for copying memory. Implementing this change will be important in ensuring that the same solidity/vyper contract compiles down to the same bytecode.´Changes the behaviour of the self destruct opcode.